[PATCH] D85201: AMDGPU/GlobalISel: Match andn2/orn2 for more types

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 05:38:41 PDT 2020


arsenm created this revision.
arsenm added reviewers: rampitec, nhaehnle, kerbowa, foad, Petar.Avramovic, mbrkusanin.
Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, rovka, yaxunl, jvesely, kzhuravl.
Herald added a project: LLVM.
arsenm requested review of this revision.
Herald added a subscriber: wdng.

Unfortunately this ends up not working as expected on targets with
16-bit operations due to AMDGPUCodeGenPrepare's promotion of uniform
16-bit ops to i32.

      

The vector case annoyingly requires switching the checked opcode,
since constants for vectors aren't directly handled.

      

I also need to think more carefully about whether this is valid for i1.


https://reviews.llvm.org/D85201

Files:
  llvm/lib/Target/AMDGPU/SIInstrInfo.td
  llvm/lib/Target/AMDGPU/SOPInstructions.td
  llvm/test/CodeGen/AMDGPU/GlobalISel/andn2.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/orn2.ll
  llvm/test/CodeGen/AMDGPU/insert_vector_elt.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85201.282880.patch
Type: text/x-patch
Size: 6122 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200804/b2def9f5/attachment.bin>


More information about the llvm-commits mailing list