[PATCH] D85024: [llvm-objdump] Implement --prefix option

[Vinicius Tinti via Phabricator via llvm-commits]

tinti added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1035
+  if (!Prefix.empty()) {
+    if (llvm::sys::path::is_absolute(LineInfo.FileName)) {
+      llvm::SmallString<128> FilePath(
----------------
MaskRay wrote:
> What if LineInfo.FileName is relative?
`--prefix` should only touch absolute paths.

I have made a wrong assumption that `--prefix` maps **absolute** paths to others **absolute** path.

That is not the case `--prefix` maps **absolute** path to **any** type of path.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85024/new/

https://reviews.llvm.org/D85024