[PATCH] D84043: [AArch64][SVE] Fix CFA calculation in presence of SVE objects.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Thanks for the reviews!



================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:440
+
+  std::string CommentBuffer = "x31";
+  llvm::raw_string_ostream Comment(CommentBuffer);
----------------
efriedma wrote:
> Why "x31" and not "sp"?
You're right, `x31` seems wrong. I've changed it to `sp` before committing.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:403-404
 
+// Convenience function to create a DWARF expression for
+//   NumBytes + NumVGScaledBytes * AArch64::VG
+static void appendVGScaledOffsetExpr(SmallVectorImpl<char> &Expr,
----------------
dblaikie wrote:
> Might be more accurate to describe this as:
> ```
> //   Expr + NumBytes + NumVGScaledBytes * AArch64::VG
> ```
> Since it includes the addition of the existing element in Expr.
Good point, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84043/new/

https://reviews.llvm.org/D84043