[PATCH] D85142: [SVE] Replace remaining _MERGE_OP1 nodes with _PRED variants.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11960
+  // ISD way to specify an all active predicate.
+  if ((Pg.getOpcode() == AArch64ISD::PTRUE) &&
+      (Pg.getConstantOperandVal(0) == AArch64SVEPredPattern::all))
----------------
efriedma wrote:
> You don't need to change it here, but should we be lowering aarch64_sve_ptrue to AArch64ISD::PTRUE, instead of supporting both forms through isel?
This lowering is already done today, I was just being unnecessarily cautious.  I removed the aarch64_sve_ptrue based path with no ill effects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85142/new/

https://reviews.llvm.org/D85142