[PATCH] D72904: [ELF] Allow SHF_LINK_ORDER sections to have sh_link=0

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 01:23:46 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks reasonable to me, but a second opinion is probably worth getting.

By the way, I realised I messed up my initial investigation I mentioned about fragmenting DWARF sections proving reasonable from a performance perspective - after I fixed the issue, a second attempt showed serious performance issues. The .group section idea will likely have the same issue, so the approach as a whole may be a non-started given the current DWARF format and cost of sections in LLD.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72904/new/

https://reviews.llvm.org/D72904



More information about the llvm-commits mailing list