[PATCH] D85179: [DebugInfo][unittest] Use YAML to generate the .debug_loclists section.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 4 00:42:34 PDT 2020
grimar added a comment.
Generally looks good for my eyes.
nit: I think the comment about intentionally missing end_of_list is better to be preserved.
================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDieTest.cpp:78
- 0, // Expression length
- // end_of_list intentionally missing
- };
----------------
// end_of_list intentionally missing
I think this comment was useful.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85179/new/
https://reviews.llvm.org/D85179
More information about the llvm-commits
mailing list