[PATCH] D85024: [llvm-objdump] Implement --prefix option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-absolute-paths-windows.test:1
+; Test --prefix options on Windows.
+
----------------
Tests which only run on Windows should be added very carefully. Many developers don't have Windows testing method. When they do refactoring, they can easily neglect Windows-only tests. `/\` has some pain but you can get round with `{{[/\\]}}`


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1035
+  if (!Prefix.empty()) {
+    if (llvm::sys::path::is_absolute(LineInfo.FileName)) {
+      llvm::SmallString<128> FilePath(
----------------
What if LineInfo.FileName is relative?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85024/new/

https://reviews.llvm.org/D85024