[PATCH] D85024: [llvm-objdump] Implement --prefix option

Mon Aug 3 18:27:21 PDT 2020

tinti added a comment.

In D85024#2190001 <https://reviews.llvm.org/D85024#2190001>, @jhenderson wrote:

> Please remember to update the documentation located at llvm/docs/CommandGuide for llvm-objdump, to include the new option.

My bad.

I believe that there are no more `docs` to be updated.

I have also removed the help text `--source` from the command line.
Both `--source` or `--line-numbers` will use the behavior implemented by `--prefix`.

I believe this is correct because:

**GNU's objdump** will not run with `--line-numbers` only.
**LLVM's objdump** assumes `--source` with `--line-numbers`.

I found a bug also in the code. By fixing **Windows** implementation I made it wrong. `--prefix my` should prepend only `my` and not `/my`.

I will compile **binutils** for **Windows** and do more tests.

Hold for a bit please but I am adding the new patch with a FIXME anyway.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85024/new/

https://reviews.llvm.org/D85024