[PATCH] D84858: [llvm-libtool-darwin] Refactor ArchiveWriter

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Object/ArchiveWriter.h:47
+                     bool Deterministic, bool Thin,
+                     std::unique_ptr<MemoryBuffer> OldArchiveBuf = nullptr);
 }
----------------
If `OldArchiveBuf` is not used (for now), delete it. It is a good idea adding a comment that this function is similar to writeArchive but has a different return type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84858/new/

https://reviews.llvm.org/D84858