[PATCH] D84043: [AArch64][SVE] Fix CFA calculation in presence of SVE objects.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Can't say I know a ton about CFI/debug_frame, unfortunately. The DWARF expression does match up with the comment - so if the intent is good, the implementation looks good to me, FWIW. (comment might be a bit clearer though, as noted)



================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:403-404
 
+// Convenience function to create a DWARF expression for
+//   NumBytes + NumVGScaledBytes * AArch64::VG
+static void appendVGScaledOffsetExpr(SmallVectorImpl<char> &Expr,
----------------
Might be more accurate to describe this as:
```
//   Expr + NumBytes + NumVGScaledBytes * AArch64::VG
```
Since it includes the addition of the existing element in Expr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84043/new/

https://reviews.llvm.org/D84043