[PATCH] D84937: [SVE][CodeGen] Fix scalable vector issues in DAGTypeLegalizer::GenWidenVectorStores

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 3 13:26:03 PDT 2020


efriedma added a comment.

It looks like this turned out pretty clean.  I like the new `+=` and `-=` operators.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:5141
                                   DAG.getVectorIdxConstant(Idx, dl));
-        StChain.push_back(DAG.getStore(
-            Chain, dl, EOp, BasePtr, ST->getPointerInfo().getWithOffset(Offset),
-            ST->getOriginalAlign(), MMOFlags, AAInfo));
+        SDValue TmpSt = DAG.getStore(Chain, dl, EOp, BasePtr, MPI,
+                                     ST->getOriginalAlign(), MMOFlags, AAInfo);
----------------
TmpSt isn't a great name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84937/new/

https://reviews.llvm.org/D84937



More information about the llvm-commits mailing list