[PATCH] D84905: [MemorySSA] Restrict optimizations after a PhiTranslation.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.

lgtm with a few tiny nits. thanks for working on this!



================
Comment at: llvm/include/llvm/Analysis/MemorySSA.h:1246
   MemoryAccess *OriginalAccess = nullptr;
   bool WalkingPhi = false;
   DominatorTree *DT = nullptr;
----------------
super tiny nit: can we bring this field below DT so we save padding in this struct's layout?


================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:530
+  // optimization walk, as merging alias results after phi translation can
+  // yield incorrect results.
+  bool PerformedPhiTranslation = false;
----------------
nit: referencing the PR might help add useful context


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84905/new/

https://reviews.llvm.org/D84905