[PATCH] D84802: Add control over debug lines dropping

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 3 12:07:36 PDT 2020


dblaikie added a comment.

Adding a flag for this seems worthy of a broader design discussion - so far we've been able to align the needs of profilers (never wanting to attribute a sample to a location that didn't actually execute - so hoisted or merged code cannot use one of its original locations) and debugger users. If that alignment is no longer going to be sufficient - I think an llvm-dev discussion about what the goals/priorities/policies are going forward would be good.

(also followed up on the previous review/commit - I've got general doubts about that patch too, that this one would not address)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84802/new/

https://reviews.llvm.org/D84802



More information about the llvm-commits mailing list