[PATCH] D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added inline comments.


================
Comment at: llvm/cmake/modules/LLVMProjectOptions.cmake:51
+
+endfunction(add_llvm_project_options)
----------------
stephenneuendorffer wrote:
> tstellar wrote:
> > Are there any of these that we can remove from LLVM, so we don't have to duplicate them for other projects?  It seems to be that we could drop all the INCLUDE_* options.  I'm guessing they exist, so that things like examples are buildable, but aren't added to the all target?  To me it seems better to automatically add everything to all, and users that want to build less then all can just specify the targets that they want to build.  Having both BUILD_* and INCLUDE_* options is very confusing.
> > 
> > 
> > 
> >  
> I'm all for simplification, but I think it's somewhat orthogonal with what I'm trying to achieve here. I agree with the general sentiment that there are just too many configuration options.
I think part of the reason why the INCLUDE configurations exists is to speed up the project generation time.  However, I don't know how much of a problem this is in practice.  I suspect that for most people compilation still takes longer than configuration. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85140/new/

https://reviews.llvm.org/D85140