[PATCH] D84233: [lit] Remove ANSI control character from xunit output
Julian Lettner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 3 10:57:12 PDT 2020
yln accepted this revision.
yln added a comment.
LGTM with two small nits. Thanks!
================
Comment at: llvm/utils/lit/lit/reports.py:71
+_xml_escape_dict = {c: None for c in range(32) if chr(c) not in ('\t', '\n', '\r')}
+
----------------
This is now an `_invalid_xml_chars_dict`
================
Comment at: llvm/utils/lit/lit/reports.py:83
+ s = s.translate(_xml_escape_dict)
+ return s
+
----------------
Why reassign `s`? Just `return`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84233/new/
https://reviews.llvm.org/D84233
More information about the llvm-commits
mailing list