[PATCH] D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added a comment.

In D85140#2191271 <https://reviews.llvm.org/D85140#2191271>, @mehdi_amini wrote:

> Something you don't make very explicit in the description of this patch is that beyond a "refactoring" this is also changing the behavior by *duplicating* the options for each subproject. 
> For example building with `-DLLVM_INCLUDE_EXAMPLES` won't be enough to include the examples in MLIR, the user must also provide `-DMLIR_INCLUDE_EXAMPLES`. Same for every other options.
>
> I can see how this provide more flexibility to the user configuring the build, but this flexibility comes also with a more complex surface. For example when building LLVM+MLIR, passing `-DLLVM_INSTALL_TOOLCHAIN_ONLY=ON` isn't enough and you need also `-DMLIR_INSTALL_TOOLCHAIN_ONLY=ON`.

That's true.  My thinking was that these should get defaults from LLVM, like MLIR_INCLUDE_DOCS already did.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85140/new/

https://reviews.llvm.org/D85140