[PATCH] D84817: Add verification for DW_AT_decl_file and DW_AT_call_file.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:88
+  if (DwarfVersion >= 5)
+    return FileNames.size() - 1;
+  return FileNames.size();
----------------
What happens if Filenames.size() == 0? Can that happen in malformed DWARF input? Otherwise can we add an assert that it isn't zero?

Should it return an Optional<uint64_t>?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84817/new/

https://reviews.llvm.org/D84817