[PATCH] D69384: [HotColdSplit] Add unlikely attribute to outlined function

Mon Aug 3 10:18:48 PDT 2020

JamesNagurne added a comment.

In D69384#2190796 <https://reviews.llvm.org/D69384#2190796>, @ostannard wrote:

> This test case has been failing on many of the ARM and AArch64 bots all weekend, e.g. http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/19408, would you mind looking into this?
>
> Here's the log of one of the failures (from http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/19408/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Acoldentrycount.ll):
>
>   ******************** TEST 'LLVM :: Transforms/HotColdSplit/coldentrycount.ll' FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 4';   /home/tcwg-buildslave/worker/clang-cmake-armv7-quick/stage1/bin/opt -hotcoldsplit -hotcoldsplit-threshold=0 -codegenprepare -S < /home/tcwg-buildslave/worker/clang-cmake-armv7-quick/llvm/llvm/test/Transforms/HotColdSplit/coldentrycount.ll | /home/tcwg-buildslave/worker/clang-cmake-armv7-quick/stage1/bin/FileCheck /home/tcwg-buildslave/worker/clang-cmake-armv7-quick/llvm/llvm/test/Transforms/HotColdSplit/coldentrycount.ll
>   --
>   Exit Code: 2
>   
>   Command Output (stderr):
>   --
>   LLVM ERROR: Trying to construct TargetPassConfig without a target machine. Scheduling a CodeGen pass without a target triple set?
>   PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace.
>   Stack dump:
>   0.	Program arguments: /home/tcwg-buildslave/worker/clang-cmake-armv7-quick/stage1/bin/opt -hotcoldsplit -hotcoldsplit-threshold=0 -codegenprepare -S 
>   FileCheck error: '<stdin>' is empty.
>   FileCheck command line:  /home/tcwg-buildslave/worker/clang-cmake-armv7-quick/stage1/bin/FileCheck /home/tcwg-buildslave/worker/clang-cmake-armv7-quick/llvm/llvm/test/Transforms/HotColdSplit/coldentrycount.ll
>   
>   --
>   
>   ********************

Our team is seeing this too. I suspect the addition of '-codegenprepare' requires the creation of the x86_64-apple target, which is not necessarily built into every compilation of LLVM.
A sure-fire way to know if this is the case would be to build LLVM with -DLLVM_TARGETS_TO_BUILD=ARM and run this test.

If it's not possible for this test to run in this case, then there should be a REQUIRES clause here, asserting that the correct target is enabled.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69384/new/

https://reviews.llvm.org/D69384