[PATCH] D85120: [ARM] Generated SSAT and USAT instructions with shift

Mon Aug 3 06:52:36 PDT 2020

dmgreen added inline comments.

================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:88
+// t2_asr_imm - Returns immediate with bit {5} set to 1
+def t2_asr_imm_XFORM : SDNodeXForm<imm, [{
+  return CurDAG->getTargetConstant(0x20 | N->getZExtValue(), SDLoc(N),
----------------
Any chance we can combine asr_imm_XFORM/asr_imm and t2_asr_imm_XFORM / t2_asr_imm to use the same SDNodeXForm? I think asr_imm  should be visible in both these files.

================
Comment at: llvm/test/CodeGen/Thumb2/thumb2-usat-with-shift.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=thumbv8.1m.main-arm-none-eabi -mattr=+mve.fp,+fp64 %s -o - | FileCheck %s
+
----------------
This can just be -mattr=+dsp I think. You could also just include this as a RUN line in the ARM/usat-with-shift.ll test if that's simpler. Up to you.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85120/new/

https://reviews.llvm.org/D85120