[PATCH] D85122: [GlobalISel][InlineAsm] Fix matching input constraint to physreg

Konstantin Schwarz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 3 06:51:01 PDT 2020


kschwarz accepted this revision.
kschwarz added a comment.
This revision is now accepted and ready to land.

LGTM, might be worth to include this also for the 11.x release.



================
Comment at: llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp:466
+            return false;
+        } else // When Def is physreg: use given input.
+          In = SrcRegs[0];
----------------
I think the `else` branch needs braces, since one of the branches need them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85122/new/

https://reviews.llvm.org/D85122



More information about the llvm-commits mailing list