[PATCH] D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions)

Mon Aug 3 06:23:10 PDT 2020

nemanjai added a comment.

In D84570#2190757 <https://reviews.llvm.org/D84570#2190757>, @nemanjai wrote:

> It would appear that this failure is not really related to this patch at all. Seems to fail with `-O0/-O1` regardless of which patch is applied.
> https://pastebin.com/1Mvz5KDz
>
> Please let me know if there's something else I can help with.

At a very quick glance, the two versions call different interceptors.
The `-O1` version calls `__interceptor_fstat` and the `-O2` version calls `__interceptor___fxstat`.
I am not sure if that reveals anything further, but that seems to be the major difference between the two.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84570/new/

https://reviews.llvm.org/D84570