[PATCH] D79767: [ARM] Macro fuse t2LoopDec and t2LoopEnd

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 3 03:48:49 PDT 2020


samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

> My understanding is that it is a terminator that produces a value, and that does not work very well. If you need to spill the value, you would have not place to spill it.

This.
It also could also have the benefit of other instructions using the value in LR too. Maybe it makes reverting easier too, but I can't even remember now... Either way, I think trying to fuse the operations is quite a bit less invasive than trying to re-implement how we do these loops :) and if it can give us some little improvements, let's do it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79767/new/

https://reviews.llvm.org/D79767



More information about the llvm-commits mailing list