[PATCH] D84763: DomTree: Make PostDomTree immune to block successors swap

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 3 02:32:11 PDT 2020


yrouban added inline comments.


================
Comment at: llvm/include/llvm/Support/GenericDomTreeConstruction.h:392
+      // reverse unreachable nodes.
+      Optional<DenseMap<NodePtr, unsigned>> SuccOrder;
+      auto InitSuccOrderOnce = [&]() {
----------------
nikic wrote:
> You might want to use a SmallDenseMap, as number of successors is usually small.
It is a successor set for all reverse unreachable nodes (like infinite loops). There are could be many of those. Ok let us try 16.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84763/new/

https://reviews.llvm.org/D84763



More information about the llvm-commits mailing list