[PATCH] D85013: [llvm-readobj] - Massive test cases cleanup.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dependent-libraries.test:37
+## Show the output when there are no dependent library sections.
+## Check that we are locating dependent library sections by type, for that we change it to an arbirtary one.
+# RUN: yaml2obj --docnum=1 -DTYPE=SHT_PROGBITS %s -o %t3
----------------



================
Comment at: llvm/test/tools/llvm-readobj/ELF/dynamic-table-dtnull.s:18
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
----------------
You might want to remove all the extra spacing in this YAML too.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/hidden-versym.test:10
 FileHeader:
   Class:             ELFCLASS64
   Data:              ELFDATA2LSB
----------------
You could probably clean up some of the spacing in this file too, if you want.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/merged.test:10
+## were supported.
+#RUN: not llvm-readobj -aeWhSrnudlVgIs %p/Inputs/trivial.obj.elf-i386 2>&1 | FileCheck %s --check-prefix=UNKNOWN
 
----------------
Nit: `# RUN:`


================
Comment at: llvm/test/tools/llvm-readobj/ELF/packed-relocs.test:30
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
----------------
Spacing clean-up?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-symbol-with-versioning.test:25
+FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
----------------
Spacing clean-up?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-symbol-with-versioning.test:38-39
     Link:            .dynstr
     AddressAlign:    0x0000000000000004
     Info:            0x0000000000000002
+    Dependencies:
----------------
Seems like you should be able to improve this YAML further by removing extra keys/replacing them with direct section name references etc? Same goes with .rela.plt below too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85013/new/

https://reviews.llvm.org/D85013