[PATCH] D85086: [ELF] --oformat=binary: use LMA to compute file offsets

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 3 01:26:18 PDT 2020


grimar added a comment.

There is a GNU ld bug about `--oformat=binary` "Linking with --oformat=binary discards non-static global variables" (https://sourceware.org/bugzilla/show_bug.cgi?id=12524).
The last 2 comments are saying:

1. //"ld --oformat is a misfeature.  Don't use it.  As you have found, it doesn't work except for the simplest of object files, and only then on a very limited set of targets.  You are much better off linking to your usual target, then converting the file with objcopy.",//
2. //"I only added support for --oformat=binary to gold because the Linux kernel build uses it.".//

So I am not sure that we want to add more complication for the existent logic of `--oformat binary` implemented in LLD?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85086/new/

https://reviews.llvm.org/D85086



More information about the llvm-commits mailing list