[PATCH] D83283: [Attributor] AAPotentialValues Interface

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added inline comments.


================
Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:351
 
+/// Provide DenseMapInfo for APInt.
+template <> struct DenseMapInfo<APInt> {
----------------
As @fhahn already mentioned, I guess you can commit DenseMapInfo part separately, as a NFC.


================
Comment at: llvm/test/Transforms/Attributor/potential.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --scrub-attributes
+; RUN: opt -attributor -attributor-manifest-internal  -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=9 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_NPM,NOT_CGSCC_OPM,NOT_TUNIT_NPM,IS__TUNIT____,IS________OPM,IS__TUNIT_OPM
----------------
Can you run the update script with `--check-attributes` to keep it in sync with other attributor tests?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83283/new/

https://reviews.llvm.org/D83283