[PATCH] D83530: [llvm-symbolizer] Switch command line parsing from llvm::cl to OptTable

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Thanks. This looks much better to me. I hope to see other users for the new higher-level API in due course!



================
Comment at: llvm/docs/CommandGuide/llvm-symbolizer.rst:223
 
 .. option:: --help-list
 
----------------
I believe this option no longer exists?


================
Comment at: llvm/include/llvm/Option/OptTable.h:236
+  /// could be parsed.
+  InputArgList parseArgs(int argc, char *const *argv, OptSpecifier Unknown,
+                         StringSaver &Saver,
----------------
`argc` -> `Argc`, `argv` -> `Argv` to silence the linter (same throughout).


================
Comment at: llvm/lib/Option/OptTable.cpp:516
+      ErrorFn("unknown argument '" + A->getAsString(Args) +
+              "', did you mean '" + Nearest + "'");
+  }
----------------
Nit: I might add a question mark to the end of this message, since it's a question.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83530/new/

https://reviews.llvm.org/D83530