[PATCH] D84733: [Attributor] Check nonnull attribute violation in AAUndefinedBehavior

[Shinji Okumura via Phabricator via llvm-commits]

okura marked 4 inline comments as done.
okura added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1993
+      unsigned ArgNum =
+          std::min(CB->getNumArgOperands(), (unsigned)Callee->arg_size());
+      for (unsigned idx = 0; idx < ArgNum; idx++) {
----------------
jdoerfert wrote:
> You don't need a callee, just use the call base.
Do you mean that I don't have to be aware of  `Callee->arg_size()` anywhere?
In the case of callbacks, `CB.getNumArgOperands() > Callee->arg_size()` holds and I got segfault when `getArg` is called.
Can I get the callee argument position directly from `CallBase`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84733/new/

https://reviews.llvm.org/D84733