[PATCH] D84976: [llvm] Add a parser from JSON to TensorSpec

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/unittests/Analysis/TFUtilsTest.cpp:116
+  auto Value = json::parse(
+      R"(
+        {"name": "tensor_name", 
----------------
How about:

`R"({`

`})");`

You can remove two lines.


================
Comment at: llvm/unittests/Analysis/TFUtilsTest.cpp:125
+  LLVMContext Ctx;
+  auto Spec = getTensorSpecFromJSON(Ctx, *Value);
+  EXPECT_FALSE(Spec.hasValue());
----------------
Expand `auto` if the type is not obvious.

https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable


================
Comment at: llvm/unittests/Analysis/TFUtilsTest.cpp:128
+}
\ No newline at end of file

----------------
No newline at end of file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84976/new/

https://reviews.llvm.org/D84976