[llvm] 08cf496 - [StackSafety, NFC] Don't insert empty objects into the map

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 2 13:59:06 PDT 2020


Author: Vitaly Buka
Date: 2020-08-02T13:58:56-07:00
New Revision: 08cf49658c1da891fb2b2cb577a89a4d6d1a7adc

URL: https://github.com/llvm/llvm-project/commit/08cf49658c1da891fb2b2cb577a89a4d6d1a7adc
DIFF: https://github.com/llvm/llvm-project/commit/08cf49658c1da891fb2b2cb577a89a4d6d1a7adc.diff

LOG: [StackSafety, NFC] Don't insert empty objects into the map

Result should be the same but it makes generateParamAccessSummary 5x
faster.

Added: 
    

Modified: 
    llvm/lib/Analysis/StackSafetyAnalysis.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/StackSafetyAnalysis.cpp b/llvm/lib/Analysis/StackSafetyAnalysis.cpp
index bbfc303aefac..bcbe9a63c182 100644
--- a/llvm/lib/Analysis/StackSafetyAnalysis.cpp
+++ b/llvm/lib/Analysis/StackSafetyAnalysis.cpp
@@ -928,7 +928,7 @@ void llvm::generateParamAccessSummary(ModuleSummaryIndex &Index) {
   for (auto &GVS : Index) {
     for (auto &GV : GVS.second.SummaryList) {
       FunctionSummary *FS = dyn_cast<FunctionSummary>(GV.get());
-      if (!FS)
+      if (!FS || FS->paramAccesses().empty())
         continue;
       if (FS->isLive() && FS->isDSOLocal()) {
         FunctionInfo<FunctionSummary> FI;


        


More information about the llvm-commits mailing list