[PATCH] D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1250
+    return ICVValuesMap[ICV].empty();
+  }
+
----------------
jdoerfert wrote:
> !empty()?
Yes, I inverted the check as well.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1324
+    if (ICVTrackingAA.isAssumedTracked())
+      return ICVTrackingAA.hasTrackedValue(ICV);
+
----------------
jdoerfert wrote:
> Does this work if the value was not "tracked", so no setter was seen, but "maybe written", by another unkown call? 
> 
> I guess we need a test where we don't call `use1` or `use` but something that then calls `use`.
You are right, this actually won't work.

I'll fix this and add a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85052/new/

https://reviews.llvm.org/D85052