[PATCH] D83283: [Attributor] AAPotentialValues Interface

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 2 03:17:00 PDT 2020


fhahn added inline comments.


================
Comment at: llvm/include/llvm/ADT/APInt.h:2293
+/// Provide DenseMapInfo for APInt.
+template <> struct DenseMapInfo<APInt> {
+  static inline APInt getEmptyKey() {
----------------
I am not sure this is the right place. Shouldn't that go into DenseMapInfo.h? Also, if this gets added there, it should probably be split off from this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83283/new/

https://reviews.llvm.org/D83283



More information about the llvm-commits mailing list