[PATCH] D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks
Stefan Stipanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 1 13:36:50 PDT 2020
sstefan1 added a comment.
In D85052#2188697 <https://reviews.llvm.org/D85052#2188697>, @jdoerfert wrote:
> This is still "intra-procedural", correct? Or can it replace across function boundaries too?
We are now able to check if call changes an ICV through function attribute. Follow up should make it possible to get an ICV value for a call.
================
Comment at: llvm/test/Transforms/OpenMP/icv_tracking.ll:19
+ ret i32 %2
+}
+
----------------
jdoerfert wrote:
> Maybe rename them to indicate if it is a `unknown_callee` or a `benign_callee`.
I think that name is more appropriate for `@use()` since we can't know if a declaration changes an ICV, right?
`@use1()` is not a great name, I agree with that. I'll change it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85052/new/
https://reviews.llvm.org/D85052
More information about the llvm-commits
mailing list