[PATCH] D84858: [llvm-libtool-darwin] Refactor ArchiveWriter
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 31 18:56:36 PDT 2020
MaskRay added inline comments.
================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:556
+static Expected<sys::fs::TempFile>
+writeArchiveInFD(StringRef ArcName, ArrayRef<NewArchiveMember> NewMembers,
+ bool WriteSymtab, object::Archive::Kind Kind,
----------------
FD might be a bit of misnomer (to me). I'd expect FD to refer to a file descriptor...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84858/new/
https://reviews.llvm.org/D84858
More information about the llvm-commits
mailing list