[PATCH] D84858: [llvm-libtool-darwin] Refactor ArchiveWriter

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:668
+  Expected<sys::fs::TempFile> Temp =
+      writeArchiveInFD(ArcName, NewMembers, WriteSymtab, Kind, Deterministic,
+                       Thin, std::move(OldArchiveBuf));
----------------
MaskRay wrote:
> I can't find writeArchiveInFD. Did you forget to add a dependent patch?
The old `writeArchive` is changed to it, in line 556 above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84858/new/

https://reviews.llvm.org/D84858