[PATCH] D81242: [StackSafety] Run ThinLTO

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 31 15:57:12 PDT 2020


vitalybuka added a comment.

In D81242#2183383 <https://reviews.llvm.org/D81242#2183383>, @tejohnson wrote:

> Is the stack safety analysis meant to be always on with ThinLTO?

During compilation most of the time it should be off.
However during linking I assume that most build FS->paramAccesses() is empty, so no hash lookup is expected. So I assume empty looks should be cheep:

  for (auto &GVS : Index) {
      for (auto &GV : GVS.second.SummaryList) {
  }}

As it paramAccesses suppose to be non-empty for MTE builds for now, so if it's not empty on internal build, then the bug it likely around why it's not empty there.
Can you send me email with internal build details?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81242/new/

https://reviews.llvm.org/D81242



More information about the llvm-commits mailing list