[PATCH] D84764: Fix computeHostNumPhysicalCores() for Linux on POWER and Linux on Z

[Ettore Tiotto via Phabricator via llvm-commits]

etiotto marked 2 inline comments as done.
etiotto added inline comments.


================
Comment at: llvm/lib/Support/Host.cpp:1275
+#elif (defined(__linux__) &&                                                   \
+       (defined(__ppc__) || defined(__powerpc__) || defined(__s390x__)))
+#include <unistd.h>
----------------
MaskRay wrote:
> `defined(__ppc__) || defined(__powerpc__) ` is redundant. 
> 
> You could just use `defined(__powerpc__)`
Other PPC code already uses both. I used both for consistency.


================
Comment at: llvm/unittests/Support/Host.cpp:45
+           (Host.getOS() == Triple::Linux &&
+            (Host.isPPC64() || Host.isSystemZ()));
   }
----------------
MaskRay wrote:
> Did you want to enable powerpc32 as well?
No


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84764/new/

https://reviews.llvm.org/D84764