[PATCH] D85040: [MSAN] Instrument freeze instruction by clearing shadow

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:4223
 
+  void visitFreezeInstruction(FreezeInst &I) {
+    // Freeze always returns a fully defined value.
----------------
This does not override anything (try visitFreezeInst).


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:4225
+    // Freeze always returns a fully defined value.
+    setShadow(&I, getCleanShadow(&I));
+  }
----------------
Need setOrigin, too.


================
Comment at: llvm/test/Instrumentation/MemorySanitizer/freeze.ll:18
+    %freeze_val = freeze i32 %val
+    ; CHECK: store i32 0, {{.*}} @__msan_retval_tls
+    ret i32 %freeze_val
----------------
This test is passing at ToT.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85040/new/

https://reviews.llvm.org/D85040