[PATCH] D84022: [flang] Fix multi-config generator builds.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

In D84022#2175761 <https://reviews.llvm.org/D84022#2175761>, @awarzynski wrote:

> To me this looks fairly straightforward. @DavidTruby , could you wait one more day before merging? Perhaps somebody else would like to review (e.g. @Meinersbur) ?

Multi-config builds usually involve `CMAKE_CFG_INTDIR`, which I do not being used here. I only built a single configuration in the MSVC IDE yet, so I wouldn't notice name clashes. I was concentrating on compiler errors anyway.

There's an `flang.sh` file involved, but one cannot assume the presence of a sh-compatible shell on Windows. Why not using a executable-relative path to `@FLANG_INTRINSIC_MODULES_DIR@` like clang does? Wouldn't it change between install-path and build-path anyway?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84022/new/

https://reviews.llvm.org/D84022