[PATCH] D85024: [llvm-objdump] Implement --prefix option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-archive-with-modified-source-path.ll:1
+; This test checks if 'llvm-objdump' works as GNU's 'objdump' with '--prefix'
+; option.
----------------
Please don't just copy `disassemble-archive-with-source.ll`

The test is named `disassemble-archive-with-modified-source-path.ll`
I wonder whether using an `archive` is significant to the test. If not, just use a plain `.o`

If an archive can trigger a slightly different code path you also want to test, you can add a second llvm-objdump RUN line for an archive.

Consider reusing an existing .ll file and not duplicating LLVM IR, e.g. source-interleave-x86_64.test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85024/new/

https://reviews.llvm.org/D85024