[PATCH] D73698: [ThinLTO] Import globals recursively

Fri Jul 31 11:00:14 PDT 2020

tejohnson added a comment.

In D73698#2187639 <https://reviews.llvm.org/D73698#2187639>, @tejohnson wrote:

> In D73698#2187540 <https://reviews.llvm.org/D73698#2187540>, @evgeny777 wrote:
>
>> Rebased/improved test case. @tejohnson Can you please look at this? I think that after D73851 <https://reviews.llvm.org/D73851> compile time regressions are unlikely (at least I don't see them in LLVM test suite)
>
> I'll take a look today and also give it a try on a large thin link to see the compile time effects.

FYI, on top of D84985 <https://reviews.llvm.org/D84985>, the thin link time for a large binary goes up from 60s to 62s (each an average of 5 runs), which isn't too bad. The number of imported globals increases significantly: 218642 to 363517.

I'll review the code changes sometime today.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73698/new/

https://reviews.llvm.org/D73698