[PATCH] D85037: [LCSSA] Use IRBuilder for PHI creation.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LGTM, but shouldn't the patch as-is should be marked as "NFC"?



================
Comment at: llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp:1773
       Instruction *Tmp;
+      IRBuilderBase::InsertPointGuard InsertPtGuard(Builder);
       if (Inst->getType()->isIntegerTy())
----------------
Why is this now needed? `fixupLCSSAFormFor()` already preserves insertion point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85037/new/

https://reviews.llvm.org/D85037