[PATCH] D84995: [AMDGPU][CostModel] Add f16, f64 and contract cases to fused costs estimation.
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 31 10:26:09 PDT 2020
rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:518
+ if ((OPC == ISD::FADD || OPC == ISD::FSUB) &&
+ (!HasFP32Denormals ||
+ (CxtI->hasAllowContract() && FAdd->hasAllowContract())))
----------------
dfukalov wrote:
> arsenm wrote:
> > The !HasFP32Denormals check is low applying to all types?
> Yes, since here we do not estimate FMUL cost, but estimate it will be fused and LLVM_FALLTHROUGH in other cases.
> Yes, since here we do not estimate FMUL cost, but estimate it will be fused and LLVM_FALLTHROUGH in other cases.
It should not affect anything except f32, and you may return Free based on fp32-denormals for any type.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84995/new/
https://reviews.llvm.org/D84995
More information about the llvm-commits
mailing list