[PATCH] D84910: [AMDGPU] Make GCNRegBankReassign assign based on subreg banks

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 31 10:21:59 PDT 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNRegBankReassign.cpp:403
         // If a register spans all banks we cannot shift it to avoid conflict.
         if (TRI->getNumCoveredRegs(LM) >= NUM_VGPR_BANKS)
           continue;
----------------
I do not like this test gone. We really need to bail here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84910/new/

https://reviews.llvm.org/D84910



More information about the llvm-commits mailing list