[PATCH] D84977: [NewPM] Only verify loop for nonskipped user loop pass

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

In D84977#2186550 <https://reviews.llvm.org/D84977#2186550>, @aeubanks wrote:

> It seems like the verification is to check either that on the first round, `LoopCanonicalizationFPM` worked, or on iterations after the first, the loop pass maintained whatever loop invariants.
> Since the `LoopPassManager` itself doesn't check for `L->isRecursivelyLCSSAForm(LAR.DT, LI)`, I don't think we should guard the check with `!isSpecialPass(Pass.name(), {"PassManager"})`.

Indeed. I was thinking in the context of callbacks which does not apply here.

> Maybe it makes more sense to mark `LoopSimplifyPass` and `LCSSAPass` as required?

We could but it sounds more like a workaround since we don't mean to run these. Applying verification when it is really needed sounds more appealing IMHO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84977/new/

https://reviews.llvm.org/D84977