[PATCH] D84763: DomTree: Make PostDomTree immune to block successors swap

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

The code looks fine to me. Have you checked if compilation times are affected by this patch?



================
Comment at: llvm/include/llvm/Support/GenericDomTreeConstruction.h:160
   // relative to IsPostDom -- using reverse edges for dominators and forward
   // edges for postdominators.
   template <bool IsReverse = false, typename DescendCondition>
----------------
Can you update the comment and explain what SuccOrder is for?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84763/new/

https://reviews.llvm.org/D84763