[PATCH] D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables
Sourabh Singh Tomar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 31 06:26:17 PDT 2020
SouraVX added inline comments.
================
Comment at: llvm/test/DebugInfo/X86/DW_AT_start_scope.ll:6
+
+; CHECK; DW_AT_name ("Local")
+; CHECK: DW_AT_decl_line (7)
----------------
Orlando wrote:
> Hi, I was just skimming the patch and noticed this.
>
> CHECK; -> CHECK:
>
> Also, since this test is only checking for a single variable, you could use `llvm-dwarfdump -name Local -` here and possibly drop this CHECK line?
Thanks for pointing this out! I'll fix this up when I revise.
BTW, please share feedback on this(overall) patch :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85018/new/
https://reviews.llvm.org/D85018
More information about the llvm-commits
mailing list