[PATCH] D85014: [Flang] Checks for constraint C7110-C7115.
David Truby via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 31 06:04:59 PDT 2020
DavidTruby requested changes to this revision.
DavidTruby added inline comments.
This revision now requires changes to proceed.
================
Comment at: flang/lib/Semantics/expression.cpp:1205
ArrayConstructorValues<SomeType> values_;
+ bool messageDisplayedOnce = false;
};
----------------
I think we usually use braces for initialization in flang, e.g.:
`bool messageDisplayedOnce {true};`
================
Comment at: flang/lib/Semantics/expression.cpp:1270
+ "of the array '%s'"_err_en_US,
+ (x->GetType())->AsFortran(), type_->AsFortran()); // C7111, C7112
}
----------------
Are these extra parentheses needed here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85014/new/
https://reviews.llvm.org/D85014
More information about the llvm-commits
mailing list