[PATCH] D84985: [ThinLTO] Compile time improvement to propagateAttributes

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added a comment.

> I made a smaller efficiency improvement (no measurable impact) to skip all summaries for a VI if the first copy is dead. I added an assert to ensure that all copies are dead if any is....

Will this work correctly in case of GUID collision? (see https://reviews.llvm.org/D67322)



================
Comment at: llvm/lib/IR/ModuleSummaryIndex.cpp:179
     assert(VI.getAccessSpecifier() == 0 || isa<FunctionSummary>(S));
+    if (!VI.isReadOnly() && !VI.isWriteOnly()) {
+      if (!MarkedNonReadWriteOnly.insert(VI).second)
----------------
nit: you can check for `!VI.getAccessSpecifier()` here and probably refactor the assertion above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84985/new/

https://reviews.llvm.org/D84985