[PATCH] D84952: [DWARFYAML] Add helper function getDWARFEmitterByName(). NFC.

Fri Jul 31 01:50:19 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:953
+
+  if (!Name.consume_front("."))
     llvm_unreachable("unexpected emitDWARF() call");
----------------
I'm not sure this check is really giving us anything. There's a check in the `getDWARFEmitterByName` that the name is a recognised name (the default case), so I think you can just remove this check here.

================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:956-958
+  Error Err = EmitFunc(*OS, DWARF);

   if (Err)
----------------
```
if (Error Err = EmitFunc(*OS, DWARF);

```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84952/new/

https://reviews.llvm.org/D84952